Metropolis Hastings with All or Nothing for Likelihood #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `test_meaning_subset` - Remove custom constructor for `Meaning` - Fix issue with custom constructor for `Grammar`
Fix Unit Tests
changed line 173 in __str__ method in src/semantics.py
information bottleneck
shanest
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Awesome; great work, Jingnong!
I left a few focused / detail-oriented comments in the code. One high-level thing I'd like to discuss is: should we make mh_sample more modular / separated out? One thing I can imagine: grammar becomes a folder/package, and then we have a module for inference that defines the algorithms (mainly MH for now).
Similarly: I wonder whether the sampling step and the acceptance step should be factored out and passed in as arguments, instead of "hard-coded" in the same mega-method. What do you think?
nathimel
force-pushed
the
metro_hastings
branch
3 times, most recently
from
36afd2d to
1005e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.